Skip to content

London | 25-SDC-July | Mikiyas Gebremichael | Sprint 1 | Debugging - Hashtag link doesnt work properly#118

Open
Mikiyas-STP wants to merge 2 commits intoCodeYourFuture:mainfrom
Mikiyas-STP:debugging/Hashtaglinkdoesntworkproperly
Open

London | 25-SDC-July | Mikiyas Gebremichael | Sprint 1 | Debugging - Hashtag link doesnt work properly#118
Mikiyas-STP wants to merge 2 commits intoCodeYourFuture:mainfrom
Mikiyas-STP:debugging/Hashtaglinkdoesntworkproperly

Conversation

@Mikiyas-STP
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Debugging - Hashtag link doesn't work properly

Questions

No question

@Mikiyas-STP Mikiyas-STP added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 5, 2026
Jinja2==3.1.5
MarkupSafe==3.0.2
psycopg2==2.9.10
psycopg2-binary==2.9.10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change this file to obtain the expected result?

if (!text) return text;
return text.replace(
/\B#[^#]+/g,
/(^|\s)(#[\w]+)/g,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why consider " \s " ( blank space ) as start of a hash tag when the start is usually the # signal ?

@wheresdiasd wheresdiasd added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants